patch to extract license data
Sam Ruby
rubys at intertwingly.net
Sun Nov 11 06:50:10 EST 2007
Asheesh Laroia wrote:
> On Wed, 7 Nov 2007, Nathan Kinkade wrote:
>
>> I've put together a small patch that will extract license data from
>> feeds and then make that data available to the templates.
>
> Hey, planet folks - any comments on this patch? It's been a few days
> with no response, so I figured I'd reping the list on N. Kinkade's behalf.
>
> It's pretty simple; I'm attaching it in case that's a preferred format.
> Do let us at CC know if it needs some changes or improvement.
>
> It takes advantage of feedparser's license extraction from feeds and
> lets you display that data in the template.
I'm not sure why I never saw the original post, but I do have a few
comments:
Per contributing[1], I would like to see some documentation, and a test.
That could be as simple as a single file in tests/data/filter/tmpl
[2], and a table row in docs/templates.html [3].
I'd gladly include a new theme that shows off cc, but I would rather the
classic fancy theme itself be left unchanged.
Finally, I'd rather that the fetching and styling of the license
information be moved into a plugin, and not placed inside the venus code
itself. Ideally, the fetching would cache the results, but if it is in
an optional plugin, I'm not overly concerned. You can look at
mememe.plugin[4] for examples on how to do all this.
- Sam Ruby
[1] http://intertwingly.net/code/venus/docs/contributing.html
[2] http://intertwingly.net/code/venus/tests/data/filter/tmpl/
[3] http://intertwingly.net/code/venus/docs/templates.html
[4] http://intertwingly.net/code/venus/filters/mememe.plugin
More information about the devel
mailing list